Add long double format option to h5dump #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Priority - 0. Blocker ⛔
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
derobins
changed the title
|
Needs a release note! |
lrknox
approved these changes
Oct 29, 2024
derobins
approved these changes
Oct 29, 2024
mattjala
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
@byrnHDF Was this file updated correctly? It looks like the --lformat wasn't applied; the data still has varying numbers of digits after the decimal
|
Yes, but I used %.4Lg and not %.04Lg
…________________________________________
From: jhendersonHDF ***@***.***>
Sent: Tuesday, October 29, 2024 10:40 AM
To: HDFGroup/hdf5
Cc: Allen Byrne; Mention
Subject: Re: [HDFGroup/hdf5] Add long double format option to h5dump (PR #5025)
@jhendersonHDF commented on this pull request.
________________________________
On tools/test/h5dump/expected/tfloatsattrs.ddl<#5025 (comment)>:
@byrnHDF<https://github.com/byrnHDF> Was this file updated correctly? It looks like the --lformat wasn't applied; the data still has varying numbers of digits after the decimal
—
Reply to this email directly, view it on GitHub<#5025 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AL77KBTPVM5L5BN2J3VKJJDZ56T6LAVCNFSM6AAAAABQYOWSO2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMBSGM2TIMZZGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Oct 31, 2024
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to fix tfloatattrs, discovered that the floating point format option did not apply to long double datatypes.
This adds the missing option.