Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor Windows warnings #5021

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Fix minor Windows warnings #5021

merged 2 commits into from
Oct 28, 2024

Conversation

derobins
Copy link
Member

  • Cast away a signed/unsigned issue in H5HFhuge.c
  • Use our platform-independent POSIX types in external_common.c and h5test.c
  • Replace a memset() call with a (const) array initializer in h5test.c
  • Fix an unused done: target in h5diff

@derobins
Fix minor Windows warnings
6b0def8 
* Cast away a signed/unsigned issue in H5HFhuge.c
* Use our platform-independent POSIX types in external_common.c
  and h5test.c
* Replace a memset() call with a (const) array initializer in h5test.c
* Fix an unused done: target in h5diff
@derobins derobins added Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - C Library Core C library issues (usually in the src directory) Component - Tools Command-line tools like h5dump, includes high-level tools Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality labels Oct 28, 2024
@derobins
Copy link
Member Author

Fixes:

  • src\H5HFhuge.c(195): warning C4018: '<=': signed/unsigned mismatch
  • test\external_common.c(65): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data
  • test\external_common.c(102): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data
  • test\h5test.c(800): warning C4090: 'function': different 'const' qualifiers
  • test\h5test.c(1650): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data
  • tools\lib\h5diff.c(1284): warning C4102: 'done': unreferenced label

@derobins derobins merged commit 369099d into HDFGroup:develop Oct 28, 2024
brtnfld pushed a commit to brtnfld/hdf5 that referenced this pull request Oct 31, 2024
@derobins @brtnfld
Fix minor Windows warnings (HDFGroup#5021)
a33537a 
* Cast away a signed/unsigned issue in H5HFhuge.c
* Use our platform-independent POSIX types in external_common.c
  and h5test.c
* Replace a memset() call with a (const) array initializer in h5test.c
* Fix an unused done: target in h5diff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF approved these changes

@qkoziol qkoziol qkoziol approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues (usually in the src directory) Component - Testing Code in test or testpar directories, GitHub workflows Component - Tools Command-line tools like h5dump, includes high-level tools Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derobins @qkoziol @byrnHDF