Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VDS examples and fix non-standalone build #3898

Merged
merged 6 commits into from
Dec 21, 2023
Merged

Add VDS examples and fix non-standalone build #3898

merged 6 commits into from
Dec 21, 2023

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Dec 19, 2023 •
edited
Loading

Add VDS examples
Fix examples build for non-standalone by skipping macros that conflict with library macros and variable names.
Fix issue with windows classpaths.
Fix doxygen links to point to new HDF5Examples folder.

@byrnHDF byrnHDF added Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Component - Java Java wrappers Component - Testing Code in test or testpar directories, GitHub workflows Component - Build CMake, Autotools Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub Type - Improvement Improvements that don't add a new feature or functionality Type - New Feature Add a new API call, functionality, or tool labels Dec 19, 2023
@byrnHDF byrnHDF self-assigned this Dec 19, 2023
@lrknox lrknox merged commit aa734a5 into HDFGroup:develop Dec 21, 2023
45 checks passed
@byrnHDF byrnHDF deleted the develop-vds-build branch January 3, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrknox lrknox lrknox approved these changes

@hyoklee hyoklee hyoklee approved these changes

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - Java Java wrappers Component - Testing Code in test or testpar directories, GitHub workflows Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub Type - Improvement Improvements that don't add a new feature or functionality Type - New Feature Add a new API call, functionality, or tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byrnHDF @hyoklee @lrknox