Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some corrections and fix for plugins #3713

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Some corrections and fix for plugins #3713

merged 1 commit into from
Oct 19, 2023

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Oct 18, 2023

Major change is in the CMake plugin files - need to remove dependencies with fetch content use.

@byrnHDF byrnHDF added Merge Use this label when a PR is for a downstream merge Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - Documentation Doxygen, markdown, etc. Component - Testing Code in test or testpar directories, GitHub workflows Component - Build CMake, Autotools Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub Type - Improvement Improvements that don't add a new feature or functionality Branch - 1.14 labels Oct 18, 2023
@byrnHDF byrnHDF self-assigned this Oct 18, 2023
@byrnHDF byrnHDF marked this pull request as draft October 18, 2023 22:13
@byrnHDF byrnHDF marked this pull request as ready for review October 19, 2023 19:53
@derobins derobins merged commit ce864f6 into HDFGroup:hdf5_1_14 Oct 19, 2023
40 checks passed
@byrnHDF byrnHDF deleted the hdf5_1_14-extra-changes branch October 22, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendersonHDF jhendersonHDF jhendersonHDF approved these changes

@derobins derobins derobins approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - Documentation Doxygen, markdown, etc. Component - Testing Code in test or testpar directories, GitHub workflows Merge Use this label when a PR is for a downstream merge Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byrnHDF @derobins @jhendersonHDF