Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the library version matrix for H5Pset_libver_bounds() #3702

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

bmribler
Copy link
Contributor

@bmribler bmribler commented Oct 17, 2023

Added 1.12, 1.14, and 1.16 to the table for libver bounds in the H5Pset_libver_bounds docs.

Note: The table can be made smaller if some of the similar notes in all the rows be combined as
common notes outside of the table. Please let me know if that is a preferred way.

Fixes GitHub #3524

bmribler and others added 2 commits October 17, 2023 17:08
Added 1.12, 1.14, and 1.16 to the table for libver bounds in the H5Pset_libver_bounds docs.
@byrnHDF byrnHDF added Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Component - Documentation Doxygen, markdown, etc. Type - Improvement Improvements that don't add a new feature or functionality labels Oct 17, 2023
@derobins derobins changed the title Fixed #3524 Update the library version matrix for H5Pset_libver_bounds() Oct 18, 2023
@derobins derobins marked this pull request as ready for review October 18, 2023 19:44
@jhendersonHDF
Copy link
Collaborator

This looks fine at a glance, but it doesn't seem maintainable to keep expanding this table for new file format versions due to the number of combinations. I'd think a more condensed explanation of what the pairs (H5F_LIBVER_EARLIEST, SPECIFIC_VERSION), (SPECIFIC_VERSION, SPECIFIC_VERSION), (H5F_LIBVER_LATEST, H5F_LIBVER_LATEST) mean would cover everything in the future.

@derobins
Copy link
Member

This looks fine at a glance, but it doesn't seem maintainable to keep expanding this table for new file format versions due to the number of combinations. I'd think a more condensed explanation of what the pairs (H5F_LIBVER_EARLIEST, SPECIFIC_VERSION), (SPECIFIC_VERSION, SPECIFIC_VERSION), (H5F_LIBVER_LATEST, H5F_LIBVER_LATEST) mean would cover everything in the future.

Agree. The combinatorial explosion needs to be contained.

I think this is fine for now, but @bmribler please create a GitHub issue to summarize the table for 1.14.4.

@lrknox lrknox merged commit 709367c into develop Oct 20, 2023
80 checks passed
jhendersonHDF pushed a commit to jhendersonHDF/hdf5 that referenced this pull request Oct 20, 2023
…p#3702)

* Fixed HDFGroup#3524

Added 1.12, 1.14, and 1.16 to the table for libver bounds in the H5Pset_libver_bounds docs.
bmribler added a commit that referenced this pull request Oct 20, 2023
derobins added a commit that referenced this pull request Oct 21, 2023
* Correct ld in format strings in cmpd_dset.c (#3697)

Removes clang warnings

* Clean up comments. (#3695)

* Add NVidia compiler support and CI (#3686)

* Work around Theta system issue failure in links test (#3710)

When the Subfiling VFD is enabled, the links test may
try to initialize the Subfiling VFD and call MPI_Init_thread.
On Theta, this appears to have an issue that will cause
the links test to fail. Reworked the test to check for
the same conditions in a more roundabout way that doesn't
involved initializing the Subfiling VFD

* Fix issue with unmatched messages in ph5diff (#3719)

* provide an alternative to mapfile for older bash (#3717)

* Attempt to quiet some warnings with cray compilers. (#3724)

* Fix CMake VOL passthrough tests by copying files to correct directory (#3721)

* Develop intel split (#3722)

* Split intel compiler flags into sub-folders
* Update Intel options for warnings
* Mostly CMake, Autotools needs additional work

* Fixes and adjustments to t_filters_parallel (#3714)

Broadcast number of datasets to create in multi-dataset I/O cases
so that interference with random number generation doesn't cause
mismatches between ranks

Set fill time for datasets to "never" by default and adjust on a
per-test basis to avoid writing fill values to chunks when it's
unnecessary

Reduce number of loops run in some tests when performing multi-dataset
I/O

Fix an issue in the "fill time never" test where data verification
could fill if file space reuse causes application buffers to be
filled with chosen fill value when reading from datasets with
uninitialized storage

Skip multi-chunk I/O test configurations for multi-dataset I/O
configurations when the TestExpress level is > 1 since those
tests can be more stressful on the file system

Disable use of persistent file free space management for now
since it occasionally runs into an infinite loop in the library's
free space management code

* Suppress cast-qual warning in H5TB Fortran wrapper (#3728)

This interface is fundamentally broken, const-wise.

* Add new API function H5Pget_actual_select_io_mode() (#2974)

This function allows the user to determine if the library performed selection I/O, vector I/O, or scalar (legacy) I/O during the last HDF5 operation performed with the provided DXPL. Expanded existing tests to check this functionality.

* Test scripts now execute in-source with creation of tmp dir (#3723)

Fixes a few issues created in #3580:

* Fixes a problem where committed tools test files were deleted when cleaning after an in-source build
* Fixes issues with test file paths in Autotools tools test scripts

* Add -h and --help as flags in h5cc & h5fc (#3729)

Adds these common help flags in addition to -help

* Update the library version matrix for H5Pset_libver_bounds() (#3702)

* Fixed #3524

Added 1.12, 1.14, and 1.16 to the table for libver bounds in the H5Pset_libver_bounds docs.

* Remove references to LIBVER_V116

---------

Co-authored-by: H. Joe Lee <[email protected]>
Co-authored-by: Allen Byrne <[email protected]>
Co-authored-by: Scot Breitenfeld <[email protected]>
Co-authored-by: Dana Robinson <[email protected]>
Co-authored-by: Neil Fortner <[email protected]>
Co-authored-by: Glenn Song <[email protected]>
Co-authored-by: bmribler <[email protected]>
bmribler added a commit to bmribler/hdf5_bmr23 that referenced this pull request Oct 21, 2023
lrknox pushed a commit that referenced this pull request Oct 22, 2023
@bmribler
Copy link
Contributor Author

This looks fine at a glance, but it doesn't seem maintainable to keep expanding this table for new file format versions due to the number of combinations. I'd think a more condensed explanation of what the pairs (H5F_LIBVER_EARLIEST, SPECIFIC_VERSION), (SPECIFIC_VERSION, SPECIFIC_VERSION), (H5F_LIBVER_LATEST, H5F_LIBVER_LATEST) mean would cover everything in the future.

Agree. The combinatorial explosion needs to be contained.

I think this is fine for now, but @bmribler please create a GitHub issue to summarize the table for 1.14.4.

GH #3773

@bmribler bmribler modified the milestone: 1.14.4 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Documentation Doxygen, markdown, etc. Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants