Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check items async not thread-safe #1686

Open
goncalodelima opened this issue Aug 26, 2024 · 3 comments
Open

check items async not thread-safe #1686

goncalodelima opened this issue Aug 26, 2024 · 3 comments
Labels

Comments

@goncalodelima
Copy link

Stack trace

.put(TickInventory.class, new TickInventory()) // Async because I've never gotten an exception from this. It's probably safe.

image

How to replicate it if known

No response

Grim version

latest

Server version

1.8.8

Plugins

[20:58:10 INFO]: Plugins (24): HamsterAPI, MinecraftSolutions, LuckPerms, WorldEdit, InventoryFramework, nChat, GrimAC, PlaceholderAPI, SwornGuns, PlugMan, packetevents, ExploitFixer, spark, WorldBorder, PlugManX, Vault, WorldGuard, Multiverse-Core, MonthlyCrates, JurassicMap, Citizens, twins-core, TAB, Legendchat

@goncalodelima
Copy link
Author

How to replicate it if known: (maybe swornguns plugin editing items at every tick) https://github.com/dmulloy2/SwornGuns

@AoElite
Copy link
Collaborator

AoElite commented Aug 30, 2024

Could probably add a setting for this if people have issues.

@goncalodelima
Copy link
Author

Would the configuration be to disable the feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants
@AoElite @goncalodelima and others