Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation false positive while sneaking between walls and fences #1670

Open
rayanbzd opened this issue Aug 21, 2024 · 7 comments
Open

Simulation false positive while sneaking between walls and fences #1670

rayanbzd opened this issue Aug 21, 2024 · 7 comments
Labels
false positive False positive simulation Related to Simulation / Prediction engine

Comments

@rayanbzd
Copy link

Describe the false positive and how to replicate it

To reproduce, simply put fences and walls every other block, then sneak and walk between it.
Video:

Enregistrer.l.ecran.2024-08-21.a.21.14.10.mov

This might be because the player can actually fit almost pixel perfect between a wall and a fence (see screenshot below)
image

So when the player sneak and walk between, maybe simulation think the player should fall in the little gap while he's not ?

Grim Log

https://paste.grim.ac/15mkupb

Server version

Paper 1.21.1 (build 35)

Client version

Vanilla 1.21

Plugins

LuckPerms, GrimAC, WorldEdit, WorldGuard, CoreProtect, and personal plugins that doesn't interfer with packets/movements.
Also reproduced on a localhost server hosted on my computer with only GrimAC on it.

@rayanbzd rayanbzd added false positive False positive simulation Related to Simulation / Prediction engine labels Aug 21, 2024
@rayanbzd
Copy link
Author

rayanbzd commented Aug 25, 2024

will be fixed in 2047

This is an issue section, not circus of sarcasm.
Fix it yourself if you think it's easy to.

@SamB440
Copy link
Collaborator

SamB440 commented Aug 25, 2024

Can you test if this happens on older client versions? Like 1.19.4. I am wondering if Mojang has changed the sneaking calculation

@rayanbzd
Copy link
Author

Can you test if this happens on older client versions? Like 1.19.4. I am wondering if Mojang has changed the sneaking calculation

Just tested in 1.19.4, same problem. The false is triggered when i'm exactly in the middle gap where it's supposed to be possible to fall in the gap between the wall and the fence.

@SamB440
Copy link
Collaborator

SamB440 commented Aug 25, 2024

Most likely related to #858

@SamB440
Copy link
Collaborator

SamB440 commented Aug 25, 2024

Interestingly it doesn't happen on my custom 1:1 simulator, I will have to see what Grim is doing wrong at some point

@rayanbzd
Copy link
Author

Just tested in old version of minecraft (1.12.2) and doesn't happen.

@rayanbzd
Copy link
Author

rayanbzd commented Sep 9, 2024

Interestingly it doesn't happen on my custom 1:1 simulator, I will have to see what Grim is doing wrong at some point

Is your custom simulator opensource ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false positive False positive simulation Related to Simulation / Prediction engine
Projects
None yet
Development

No branches or pull requests

2 participants