Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroundSpoof and Simulation false when dimension minY incorrect #1663

Closed
Ayouuuu opened this issue Aug 20, 2024 · 6 comments
Closed

GroundSpoof and Simulation false when dimension minY incorrect #1663

Ayouuuu opened this issue Aug 20, 2024 · 6 comments
Labels
false positive False positive packetevents Caused by PacketEvents

Comments

@Ayouuuu
Copy link
Contributor

Ayouuuu commented Aug 20, 2024

Describe the false positive and how to replicate it

  1. Download this paper 1.18.2
  2. Put grim-2.3.67.jar into plugins
  3. Run server
  4. Join Server
  5. false...

Grim version

grim-2.3.67

Server version

Paper 1.18.2

Plugins

GrimAC

@Ayouuuu Ayouuuu added the false positive False positive label Aug 20, 2024
@SamB440
Copy link
Collaborator

SamB440 commented Aug 20, 2024

What do you mean 'dimension minY incorrect'? Grim already checks for world height, if the world height it gets is incorrect then report this issue to packetevents

@Ayouuuu Ayouuuu closed this as completed Aug 20, 2024
@Ayouuuu
Copy link
Contributor Author

Ayouuuu commented Aug 20, 2024

But setDimension() getMinY() and getHeight() method return static DimensionTypes OVERWORLD value, if you get the heights directly from the NBT like this commit, it works fine.

#1659

@SamB440
Copy link
Collaborator

SamB440 commented Aug 22, 2024

Can this be closed by the latest commit? idk if this is the same as the other 2

@Ayouuuu
Copy link
Contributor Author

Ayouuuu commented Aug 22, 2024

Can this be closed by the latest commit? idk if this is the same as the other 2

I just tested it latest commit artifact still not work
I think that's the problem here

@SamB440 SamB440 added the packetevents Caused by PacketEvents label Aug 22, 2024
@ChicknTurtle
Copy link

I have this issue with grim 2.3.66 on paper 1.21.1
I am using amplified nether + amplified nether height datapacks
I can't move on blocks above y256

@Ayouuuu
Copy link
Contributor Author

Ayouuuu commented Sep 24, 2024

fixed

@Ayouuuu Ayouuuu closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false positive False positive packetevents Caused by PacketEvents
Projects
None yet
Development

No branches or pull requests

3 participants