Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tierByVoltage MAX tier off by one #2626

Merged
merged 1 commit into from
Sep 22, 2024
Merged

fix tierByVoltage MAX tier off by one #2626

merged 1 commit into from
Sep 22, 2024
+1 −1

Conversation

TechLord22
Copy link
Member

@TechLord22 TechLord22 commented Sep 22, 2024 •
edited
Loading

What

Fixes an off by one error introduced in #2617. MAX is now 1 << 31 instead of (1 << 31) - 1, which means Integer.MAX_VALUE no longer indicates MAX tier.

@TechLord22 TechLord22 requested a review from a team as a code owner September 22, 2024 05:52
@TechLord22 TechLord22 added the ignore changelog PR should not be added to the changelog. label Sep 22, 2024
@TechLord22 TechLord22 merged commit ca583bc into master Sep 22, 2024
3 of 4 checks passed
@TechLord22 TechLord22 deleted the tc/fix-tier-by-voltage branch September 22, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghzdude ghzdude ghzdude approved these changes

Assignees
No one assigned
Labels
ignore changelog PR should not be added to the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TechLord22 @ghzdude