Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleMachineMetaTileEntity makes it easy to change the logo #2289

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

tier940
Copy link
Contributor

@tier940 tier940 commented Dec 13, 2023

What

Until now, if you want to change the logo of a simple machine, you have to extend the SimpleMachineMetaTileEntity.
For multi block machine @Override of the logo is possible, so we changed the specification to the same one.

Implementation Details

Improved hard coding of logo.

Potential Compatibility Issues

none

@tier940 tier940 requested a review from a team as a code owner December 13, 2023 02:09
@ALongStringOfNumbers ALongStringOfNumbers added the type: feature New feature or request label Dec 13, 2023
@tier940 tier940 changed the title SimpleMTE also makes it easy to change the logo SimpleMachineMetaTileEntity also makes it easy to change the logo Dec 13, 2023
@tier940 tier940 changed the title SimpleMachineMetaTileEntity also makes it easy to change the logo SimpleMachineMetaTileEntity makes it easy to change the logo Dec 13, 2023
@tier940
Copy link
Contributor Author

tier940 commented Apr 2, 2024

When are you planning to do this merge?
As in my coremod, this fix should be welcome in other coremods or addon.

@bruberu bruberu enabled auto-merge (squash) June 6, 2024 14:45
@TechLord22 TechLord22 disabled auto-merge July 28, 2024 17:37
@TechLord22 TechLord22 merged commit 69489e1 into GregTechCEu:master Jul 28, 2024
4 of 5 checks passed
@tier940 tier940 deleted the tier-mte-single-logo branch July 28, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants