Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with ore byproduct page #2262

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Fix issues with ore byproduct page #2262

merged 2 commits into from
Dec 7, 2023

Conversation

serenibyss
Copy link
Member

  • Fix ore byproduct page no longer showing the text overlays for output chance
  • Fix ore byproduct page not using the BLINKING_CYAN text color for byproduct chance tooltip

@serenibyss serenibyss added the type: bug Something isn't working label Dec 7, 2023
@serenibyss serenibyss requested a review from a team as a code owner December 7, 2023 02:07
@YoungOnionMC
Copy link
Contributor

Looks good

@YoungOnionMC
Copy link
Contributor

This is an Approval action done by a real Team member

ghzdude
ghzdude approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@ghzdude ghzdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on behalf of onion

@serenibyss serenibyss merged commit f835f80 into master Dec 7, 2023
4 checks passed
@serenibyss serenibyss deleted the sb-fix-orebyproduct-page branch December 7, 2023 03:06
serenibyss added a commit that referenced this pull request Dec 11, 2023
@serenibyss
Fix issues with ore byproduct page (#2262)
625c296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghzdude ghzdude ghzdude approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serenibyss @YoungOnionMC @ghzdude