Revise bloom render ticket API #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htmlcsjs
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR revises bloom render ticket API introduced in the last release, fixing the issue related to dangling bloom effects in process.
Additionally, this PR fixes fusion reactors not removing fusion ring effect correctly on structure invalidation.
Implementation Details
I am hungry
Outcome
Burger
Additional Information
Technically this PR is API breaking but double technically this PR isn't actually API breaking because bloom stuff is not a part of API lmao gottem
Ignore editorconfig changes
Potential Compatibility Issues
I am still hungry