Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added index to shape info for multiblock preview #2171

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

YoungOnionMC
Copy link
Contributor

What

Allows for Multiple Shapes in a ShapeInfo list to be drawn

Implementation Details

Gave an index for which specific shape info to draw

Outcome

draws the correct shape info.

@YoungOnionMC YoungOnionMC requested a review from a team as a code owner November 16, 2023 07:33
@ALongStringOfNumbers ALongStringOfNumbers added the type: feature New feature or request label Nov 16, 2023
Comment on lines 310 to 332
public int getTier() {
return this.structureTier;
}

/**
* sets the tier of the multi clamped between 1 and maxTier()
*/
public void setTier(int structureTier) {
if(this.structureTier != structureTier) {
this.structureTier = MathHelper.clamp(structureTier, 0, getMaxTier());
if (getWorld() != null && !getWorld().isRemote) {
reinitializeStructurePattern();
}
}
}

/**
* Override if you are using the multiblock tiered system
* max tier of 0 means tiering is disabled
*/
public int getMaxTier() {
return 0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these methods should be called structure tier not tier, too general for this low down of methods

@@ -423,6 +423,11 @@ public Builder addFuelNeededLine(String fuelName, int previousRecipeDuration) {
return this;
}

public Builder addTieringLine(int tier) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addStructureTierLine(int tier)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants