-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added index to shape info for multiblock preview #2171
Open
YoungOnionMC
wants to merge
8
commits into
GregTechCEu:master
Choose a base branch
from
YoungOnionMC:yo-preview-render
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and jei preview, note does not save to world yet!!!
serenibyss
reviewed
Dec 16, 2023
Comment on lines
310
to
332
public int getTier() { | ||
return this.structureTier; | ||
} | ||
|
||
/** | ||
* sets the tier of the multi clamped between 1 and maxTier() | ||
*/ | ||
public void setTier(int structureTier) { | ||
if(this.structureTier != structureTier) { | ||
this.structureTier = MathHelper.clamp(structureTier, 0, getMaxTier()); | ||
if (getWorld() != null && !getWorld().isRemote) { | ||
reinitializeStructurePattern(); | ||
} | ||
} | ||
} | ||
|
||
/** | ||
* Override if you are using the multiblock tiered system | ||
* max tier of 0 means tiering is disabled | ||
*/ | ||
public int getMaxTier() { | ||
return 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these methods should be called structure tier
not tier
, too general for this low down of methods
@@ -423,6 +423,11 @@ public Builder addFuelNeededLine(String fuelName, int previousRecipeDuration) { | |||
return this; | |||
} | |||
|
|||
public Builder addTieringLine(int tier) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addStructureTierLine(int tier)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allows for Multiple Shapes in a ShapeInfo list to be drawn
Implementation Details
Gave an index for which specific shape info to draw
Outcome
draws the correct shape info.