Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crates and drums don't stack when mined #2310

Open
2 tasks done
SylviBlossom opened this issue Nov 11, 2024 · 1 comment
Open
2 tasks done

Crates and drums don't stack when mined #2310

SylviBlossom opened this issue Nov 11, 2024 · 1 comment
Labels
type: bug Something isn't working

Comments

@SylviBlossom
Copy link

Checked for existing issues

  • I have checked for existing issues, and have found none.

Tested latest version

  • I have checked that this occurs on the latest version.

GregTech CEu Version

v1.4.6

Minecraft Version

1.20.1

Recipe Viewer Installed

EMI

Environment

Singleplayer

Cross-Mod Interaction

No

Other Installed Mods

EMI

Expected Behavior

Empty crates and drums stack with eachother

Actual Behavior

When mined, both crates and drums drop with useless NBT which prevents their stacking.

Steps to Reproduce

  1. Get a stack of empty drums/crates from any source other than mining one (e.g. crafting, item giver, machine GUI interaction)
  2. Place one in the world
  3. Break it and pick up the item, no longer stacking

Additional Information

In the case of drums, the tag is a minecraft:empty fluid of size 0, visually displayed with a "Fluid Stored: Air, 0 mB" tooltip vs no "Fluid Stored" tooltip by default. This useless NBT is removed when the drum is emptied any other way (machine GUI interaction / emptying by crafting).
image
In crates, this is just an empty tag, and is as far as I can tell only resolvable by dropping a stackable and non-stackable crate on the ground and weird minecraft behaviour ignores the empty tag when combining dropped item stacks.
image

@SylviBlossom SylviBlossom added the type: bug Something isn't working label Nov 11, 2024
@SylviBlossom
Copy link
Author

I also didn't notice this applies to non-empty drums as well, because the fluid Amount tag is an int after machine GUI interaction (left-clicking a fluid slot with a drum) but a long when mined (not sure if this would be fixed with the in-dev fluid changes)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant