Cloud Carbon Foot Print Implementation #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
gnanakeethan
force-pushed
the
ccf-imp
branch
3 times, most recently
from
c25baee
to
4e6887f
Compare
8 tasks
gnanakeethan
force-pushed
the
ccf-imp
branch
3 times, most recently
from
2d33e1e
to
4d14d73
Compare
jawache
reviewed
Aug 20, 2023
There was a problem hiding this comment.
This isn't approved by me I think @narekhovhannisyan and Cameron should take a look also but just some comments for now.
|
I am finding some conflict in the instance list vs the handwritten mapping. There are multiple architectures associated with a single instance family in GCP. Instance List Can you please confirm if we should average all three and calculate further on? |
gnanakeethan
force-pushed
the
ccf-imp
branch
3 times, most recently
from
5d88721
to
6ddb0a7
Compare
|
@narekhovhannisyan Please review. I have pushed and patched on top of dev. |
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
Signed-off-by: Gnanakeethan Balasubramaniam <[email protected]>
jawache
approved these changes
Aug 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the CCF Version of the IEF.
Provides the standard interface for calculating usage.