Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move aggregation param definition to plugin metadata #916

Closed
4 tasks done
jmcook1186 opened this issue Jul 22, 2024 · 2 comments · Fixed by #919
Closed
4 tasks done

Move aggregation param definition to plugin metadata #916

jmcook1186 opened this issue Jul 22, 2024 · 2 comments · Fixed by #919
Assignees

Comments

@jmcook1186
Copy link
Contributor

jmcook1186 commented Jul 22, 2024

What
We currently expect aggregation method to b e set in aggregation config in the manifest. However, time-sync expects to find those data for every parameter, not just those that are being aggregated. This means we need to incorporate the aggregationMethod into the plugin metadata so it can be handled the same way as units and prevent time sync from falling back to default method uneccessarily.

Plugins should have default values defined in their source code but should be overrideable from the manifest, as per the units.

Why
To prevent time sync from resorting to fallback aggregation methods and emitting lots of warnings.

Context
Part of the upgrade to phased execution

Prerequisites/resources
n/a

SoW (scope of work)

  • add aggregationMethod field to the plugin metadata
  • make time-sync check for aggregation method in the plugin metadata instead of in the aggregation config block
  • test cases added

Acceptance criteria

  • test manifests execute correctly using aggregation methods loaded from plugin metadata.
@zanete
Copy link

zanete commented Jul 24, 2024

@jmcook1186 @narekhovhannisyan please review the PR that @manushak will link shortly :)

@zanete
Copy link

zanete commented Jul 25, 2024

need to update the IF core an instead of Joseph as second reviewer, we can ask @MariamKhalatova to review instead so that this can unblock the manifest updates

@zanete zanete assigned MariamKhalatova and unassigned jmcook1186 Jul 25, 2024
@manushak manushak linked a pull request Jul 26, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants