Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cloud-metadata readme file #77

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Update cloud-metadata readme file #77

merged 3 commits into from
Apr 11, 2024

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • add description of the fields
  • rename cim to cloud-metadata

@manushak manushak added size: small quick task awaiting-dev-review PR is awaiting review from core dev fix PR fixes a bug or improves something labels Apr 10, 2024
@manushak manushak self-assigned this Apr 10, 2024
@manushak manushak linked an issue Apr 10, 2024 that may be closed by this pull request
Update cloud-metadata readme file Green-Software-Foundation/if#609
Closed
@manushak manushak changed the title Add description of the fields Update cloud-metadata readme file Apr 10, 2024
@narekhovhannisyan narekhovhannisyan added dev-review-pass PR has been approved by core dev awaiting-qa PR is waiting for QA approval and removed awaiting-dev-review PR is awaiting review from core dev labels Apr 10, 2024
@jmcook1186
Copy link
Contributor

@manushak these updates are not clear to me - there's no fields parameter in the manifest in the if repo, nor is it included int he example manifest in the readme documentation. Is it optional? If so, can we make that clear in the readme doc please?

@jmcook1186 jmcook1186 merged commit e1b1e6b into main Apr 11, 2024
2 checks passed
@jmcook1186 jmcook1186 deleted the cloud-metadata-doc branch April 11, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

@MariamKhalatova MariamKhalatova Awaiting requested review from MariamKhalatova

Assignees

@manushak manushak

Labels
awaiting-qa PR is waiting for QA approval dev-review-pass PR has been approved by core dev fix PR fixes a bug or improves something size: small quick task
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update cloud-metadata readme file
3 participants
@manushak @jmcook1186 @narekhovhannisyan