Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e-net and e-mem plugins #62

Merged
merged 12 commits into from
Apr 1, 2024
Merged

Fix e-net and e-mem plugins #62

merged 12 commits into from
Apr 1, 2024

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • before getting the energy-per-gb, check the globalConfig

@jmcook1186 jmcook1186 added bug Something isn't working medium-priority medium priority issue size: small quick task awaiting-dev-review PR is awaiting review from core dev labels Mar 28, 2024
@jmcook1186 jmcook1186 added awaiting-qa PR is waiting for QA approval and removed awaiting-dev-review PR is awaiting review from core dev labels Mar 28, 2024
@MariamKhalatova MariamKhalatova merged commit 879bf2a into main Apr 1, 2024
2 checks passed
@MariamKhalatova MariamKhalatova deleted the fix-e-net-mem branch April 1, 2024 20:25
@MariamKhalatova MariamKhalatova added qa-pass PR has passed QA and removed awaiting-qa PR is waiting for QA approval labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamKhalatova MariamKhalatova MariamKhalatova approved these changes

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

Assignees

@manushak manushak

Labels
bug Something isn't working medium-priority medium priority issue qa-pass PR has passed QA size: small quick task
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manushak @narekhovhannisyan @jmcook1186 @MariamKhalatova