Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: WattTime provides marginal while Electricity Map provides average signal #573

Open
1 task done
Ravichou opened this issue Oct 4, 2024 · 1 comment
Open
1 task done
Labels
documentation Improvements or additions to documentation

Comments

@Ravichou
Copy link

Ravichou commented Oct 4, 2024

Contact Details

[email protected]

Overview of Change

Hello,

The documentation of the Web API states that it provides "the marginal carbon intensity for a given location and time period".

However, looking at the implementation of the Electricity Map API, here , there, and there, it seems like the SDK retrieves the average signal from the Electricity Map, not the marginal one.

Furthermore this difference with the WattTime API could also be explicited in the selecting a datasource tutorial, as I believe this a significant feature difference between both APIs.

From the SCI standpoint, this is fine, as it accepts both marginal and average signals. However I think this should be explicited in the doc: remove the 'marginal' in the Web API doc, and explicit the different behavior in the data source doc.

Thanks and best regards,
Robin

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Ravichou Ravichou added the documentation Improvements or additions to documentation label Oct 4, 2024
@danuw
Copy link
Collaborator

danuw commented Nov 4, 2024

Thank you very much @Ravichou for noticing this. I have not yet looked at the details but the Electricity Map implementation came later so that part of the doc must only comply with the old stuff.

Are you able to provide a pull request matching your suggestions please? That would help speed up a fix.

Let me/us know. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants