-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Contribution]: Multiple data source support #345
Comments
@YaSuenag This seems worthy of an ADR. |
This seems like it is more related to ADR-008. Either way, happy to collaborate. My personal preference is to create new ADRs and add a reference to existing ADRs impacted by the new one. For example:
Unless @vaughanknight or @Willmish has a different preference for this project |
From call #349 : Data from WattTime and data in ElectricityMaps is different - (one uses marginal the other uses average( might not be comparable between different locations using different data sources. So important thing to point out here is, how do we ensure users are aware where the data comes from and that it might be different/not comparable between different locations if used from different datasources (marginal vs average)
|
Update from meeting #355: not crticial for 1.1, rather a feature for 1.2. Open to discussion |
This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically. |
This issue has not had any activity for too long. If you believe this issue has been closed in error, please contact an administrator to re-open, or if absolutly relevant and necessary, create a new issue referencing this one. |
What happened?
I proposed this feature in #343 (comment) .
Carbon Aware SDK supports just one data source as following:
Granularity and covered area vary in each data souces. Some SDK users want to use WattTime as a first priority, but they might want to use ElectricityMaps when they want to know emission data of uncovered area in WattTime.
So I'd like to propose mutiple data source support as following:
In above case, both
EmissionsDataSouce
andForecastDataSouces
are array. Lower index is higher priority. For example inEmissionData
,WattTime
is the highest priority, but no emission data for given location in WattTime, it would fallback toElectricityMaps
.Code of Conduct
Feature Commitment
The text was updated successfully, but these errors were encountered: