-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Fix and update doc deployment workflow #344
Comments
We definitely want the latest docs to be reflected on the website. To be honest we should consider in general whether we should have a web deployed docs or keep it purely in GH. I personally am for maintaining both, ideally keeping all documents in the docs folder so they are buildable with a tool like Sphinx https://www.sphinx-doc.org/en/master/ , we can then add a GH action that redeploys the docs on any changes to the docs/ folder @vaughanknight @danuw what do you guys think? FYI: Current docs deployed look like this: https://green-software-foundation.github.io/carbon-aware-sdk/ |
Feedback from the Open Source WG: other GSF projects (SCI ) use docasaurus which use mdx files and would require some modification of existing documentation, but we would then stick with consistency |
Update #358 : no update, open for contributors to pick up - to bring up during OSS - where to add static content for the dcosaurs to build? Is it possible to do it dynamically from our docs folder as well? |
Shouldn't we reopen this? Looks like it was closed by mistake @Willmish (Started taking a look at docusaurus. Looking at how it works for now and how to leverage the root docs folder ideally...) |
@YaSuenag branch is on my fork at the mo. I have pushed everything - note I have not yet moved files from docs to casdk-docs/docs Let me know if you need my help but I have a feeling what you are after is another folder (like blog and docs) |
form #384: @danuw to share screenshots from his local demo using the existing docs folder in the @YaSuenag PR #359 has a ready generation of docs, but if we generate from a different branch the draft pr needs to be repointed to a different branch
|
Main challenge remaining is around sample docs... on how to integrate with it... |
Hi @osamajandali, @jawache suggested to get in touch with you about this. We are trying to revive the docusauraus/docs website for the repo. I currently have a branch that compiles to the above screenshots. Considerations:
Latest hurdle to tackle is around docs available in the Are you able to help? do you have any suggestions? Let me know |
Hi @danuw, |
Hi @osamajandali Can you access it? |
Pending action here is that the deployment pipeline does not error but only works partially. It deploys to This shows that changes get deployed - although I could test by adding a file in particular and removing it afterwards to make sure updates do occur (will test that now and report back) |
I think the deployment does not work actually ... test file if visible in the locally run instance, but not in the github pages after the workflow successfully completed ... @osamajandali any ideas please? EDIT: additionally the file is in the gh-pages branch https://github.com/Green-Software-Foundation/carbon-aware-sdk/blob/gh-pages/docs/test.html EDIT2: I am trying to go through the yarn deploy step to understand better what could fail (ref) |
All sorted - basically I still needed the config to deploy from GitHub pages branch even though I have my own workflow to deploy. So left to do:
|
thanks @danuw, would anything in that list you've added need input from @osamajandali or can I remove his name from the assignee list? 🙏 |
Hi @zanete you can remove. Thank you |
(Fyi a copy paste of the themes from IF docs did not work out of the box, so something to come back to, after 1.3 release) |
Order for reference
|
@danuw happy to close this issue off now? |
Sure that can probably be be closed but still waiting for PR to be approved by the team. @zanete yes you can remove his name if you need. Thank you |
Contact Details
No response
What happened?
The following worklfow builds documentation that has not run for over a year.
https://github.com/Green-Software-Foundation/carbon-aware-sdk/actions/workflows/pages/pages-build-deployment
Do we need to fix so the latest gets deployed in a format that may be issue to consume by others?
Other projects in GSF use Docasaurus to build their documentation, an example such project is : https://github.com/Green-Software-Foundation/sci-guide , currently deployed to : https://sci-guide.greensoftware.foundation/
Best solution to this issue would involve - restructuring the current docs to be buildable and deployable as a Docasaurus project on github pages.
Code of Conduct
The text was updated successfully, but these errors were encountered: