Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Carbon Aware Azure Functions / nuget with -IncludeReferencedProject #306

Closed
1 task done
georgekosmidis opened this issue Feb 27, 2023 · 6 comments
Closed
1 task done
Labels
bug Something isn't working for discussion Tabled for discussion in weekly team call

Comments

@georgekosmidis
Copy link

Contact Details

[email protected]

What happened?

Hello all,

I ve been working on a small piece of code that brings the Carbon Aware SDK to Azure Functions (you can check it here: https://github.com/georgekosmidis/Greenhopper).

I ve been pulling Carbon Aware SDK repo as a submodule and using parts of it in my solution as a code reference. This works well for developing but when I am trying to pack it as nuget with -IncludeReferencedProjects i get the following error (upon referencing the nuget package):

Assembly 'Greenhopper' with identity 'Greenhopper, Version=0.3.4.0, Culture=neutral, PublicKeyToken=null' uses 'Microsoft.Extensions.Hosting.Abstractions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' which has a higher version than referenced assembly 'Microsoft.Extensions.Hosting.Abstractions' with identity 'Microsoft.Extensions.Hosting.Abstractions, Version=5.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'

Is there a chance we could somehow align on the versions, at least up until there is nuget package?

Thanks!

P.S.

client

WebAPI (Default)

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@georgekosmidis georgekosmidis added the bug Something isn't working label Feb 27, 2023
@georgekosmidis
Copy link
Author

Hey @danuw,
this is the issue requested at #304

@danuw danuw added the for discussion Tabled for discussion in weekly team call label Feb 27, 2023
@Willmish
Copy link
Collaborator

Willmish commented Mar 7, 2023

Hi @georgekosmidis - thanks for raising this. From what I understand you are in contact with @vaughanknight as well - we just had a weekly project sync with other members of the GSF (#314 ) during which your issue was briefly discussed.

There will be further discussions on this, but it would be helpful if contributors from #224 could look at this as it might be related? (@pritipath ) Can anything be done on this without releasing a CA SDK NuGet package ourselves? Would this require us to keep updating dev with most recent package versions?

@Willmish
Copy link
Collaborator

Willmish commented Mar 7, 2023

What I forsee as a possible solution is v1.1 being on track to be released soon, and it most likely has all the features you are currently using and you will be able to align to that. But lets hear others' input as well

@georgekosmidis
Copy link
Author

I can happily say, that after just a few hundreds of attempts, I finally managed to have a nuget package working :):):)

Greenhopper v1.0.0 is out there!

@danuw
Copy link
Collaborator

danuw commented May 2, 2023

That is great news - well done. Anything you might be able to contribute back to help improve the repo?

If nothing, please can you confirm if we can close this issue?

@georgekosmidis
Copy link
Author

I would very much like to see a nuget package out of this repo as it will simplify usage all around, and I am willing to contribute to that, but for now no, i do not have anything else to add.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working for discussion Tabled for discussion in weekly team call
Projects
None yet
Development

No branches or pull requests

3 participants