Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Contribution]: Geocode support in the API #179

Open
2 tasks done
vaughanknight opened this issue Oct 27, 2022 · 10 comments
Open
2 tasks done

[Feature Contribution]: Geocode support in the API #179

vaughanknight opened this issue Oct 27, 2022 · 10 comments
Assignees
Labels
for discussion Tabled for discussion in weekly team call

Comments

@vaughanknight
Copy link
Contributor

What happened?

While cloud datacenters lean towards having named locations (not having to remember geocodes) when looking at client side carbon aware decisions, the use case for geocoordinates is very strong.

This feature would be to add geocode support to any of the API's where named locations are supported (and geocodes are not).

This is likely a large change, and will need considerable impact analysis to ensure we do it cleanly.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Feature Commitment

  • I commit to contributing this feature as a PR and working with the GSF to merge this feature into the Carbon Aware SDK.
@vaughanknight vaughanknight self-assigned this Oct 27, 2022
@vaughanknight vaughanknight added the v1.1 Issues/PRs around v1.1 release label Nov 1, 2022
@Willmish
Copy link
Collaborator

Willmish commented Mar 1, 2023

Mentioned in #115

@bderusha
Copy link
Contributor

This feature unlocks many use-cases around end user device carbon awareness. EG home computer: time-shifted file downloads, uploads; smart home devices: managing power consumption for car chargers, appliances, etc.

Design Recommendations

  • Ability to configure multiple LocationSources and have them applied in a specific order.
  • Keep location input type as single string value (even for lat,long geospacial coordinates) and let the location source resolve the string into something well-formed.
  • Caching needs to be considered here. Whether it's documenting a recommended approach for operators to put in front of the SDK or baking it into the solution. But simply using a geocoordinate as the key will have many cache misses, it would be great to have a solution that handles that a bit smarter.

@bderusha
Copy link
Contributor

Another comment on this:

Having multiple LocationSources is a significant change that should have an approved ADR before it is implemented.

@Willmish
Copy link
Collaborator

Update from #355 : Lot of possible implications from the carbon perspective (might allow for not a good use of the CA SDK). Not on track for v1.1, looking to implement in v1.2.

@Willmish
Copy link
Collaborator

Update from #384: we are post v1.1 release, so this again is open for discussions and implementation considerations

Copy link
Contributor

This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically.

@github-actions github-actions bot added the stale label Dec 14, 2023
@danuw
Copy link
Collaborator

danuw commented Jan 2, 2024

@Willmish shall we owe this? I feel this is needed.

@github-actions github-actions bot removed the stale label Jan 2, 2024
Copy link
Contributor

github-actions bot commented May 1, 2024

This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically.

@github-actions github-actions bot added the stale label May 1, 2024
@danuw danuw removed stale v1.1 Issues/PRs around v1.1 release labels May 1, 2024
Copy link
Contributor

This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically.

@danuw
Copy link
Collaborator

danuw commented Sep 3, 2024

This should still be on our raodmap, however low as this is a request that comes back often - wonder if next time we get a request, we also get a PR for a suggested implementation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for discussion Tabled for discussion in weekly team call
Projects
None yet
Development

No branches or pull requests

4 participants