Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG -- numpy>2 raises ValueError. #131

Open
it176131 opened this issue Oct 2, 2024 · 2 comments
Open

BUG -- numpy>2 raises ValueError. #131

it176131 opened this issue Oct 2, 2024 · 2 comments

Comments

@it176131
Copy link

it176131 commented Oct 2, 2024

To recreate (using Python 3.12 on Windows):

$ py -3.12 -m venv env
$ source env/Scripts/activate
$ python -m pip install -U pip
$ pip install suitesparse-graphblas
$ python -c "import suitesparse_graphblas"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "~\env\Lib\site-packages\suitesparse_graphblas\__init__.py", line 18, in <module>
    from . import utils
  File "suitesparse_graphblas\\utils.pyx", line 1, in init suitesparse_graphblas.utils
ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

Related: #130

@eriknw
Copy link
Member

eriknw commented Oct 3, 2024

Thanks for the bug report!

It looks like #130 is a WIP to support NumPy 2, and the main thing that is needed is to rebuild wheels using NumPy 2:
https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/130/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711L9-R9

To get automated wheels working again, it looks like we need to do some updates for cibuildwheel as was also done in #128.

@alugowski
Copy link
Collaborator

To get automated wheels working again, it looks like we need to do some updates for cibuildwheel as was also done in #128.

@eriknw #128 is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants