-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate recurrence type sections #63
Open
ghost
wants to merge
14
commits into
GothenburgBitFactory:master
Choose a base branch
from
unknown repository
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ability for the user to define which day of the week should be considered the start of the week, was added in [4ab665b8764b3fe67b2bd63acf7d68f2eb97b911](GothenburgBitFactory/taskwarrior@4ab665b) and [fd823871f0ee840288d3b4fdd095cc2970f8adad](GothenburgBitFactory/taskwarrior@fd82387).
Otherwise, due to bootstrap.css, the "h5" headings end up with the same size, weight, and decoration as the "p" element text and are not visually obvious as headings.
Clarify similarities between these two programs' recurrence types, by incorporating material from [this comment](GothenburgBitFactory/taskwarrior#1835 (comment)). Strip extraneous prose.
into "Proposal: New 'rtype' attribute", for concision.
Both because that seems the most relevant place for it, and because the table was too narrow to accommodate so many columns with cells containing full sentences of text. Also delete the now-unnecessary "Notes" column from the `rtype` proposal table.
If you are very late buying birthday flowers, it might be better to wait until next year (depends on the person, I guess). But rent is more black-and-white: it is due regularly, and if not paid then the obligations accumulate. The replacement example was inspired by one of the examples given at https://orgmode.org/manual/Repeated-tasks.html
Useful to help distinguish it from `rtype:periodic` and `rtype:chained`. The replacement example was inspired by one of the examples given at https://orgmode.org/manual/Repeated-tasks.html
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce fragmentation of
rtype
considerations across document.