Updater does not respect proxy settings from --proxy-server=.
#184
Comments
Richardn2002
added a commit
to Richardn2002/OpenAsar
that referenced
this issue
Jul 9, 2024
…pdates. At least I can confirm that `versions.json` retrieval uses proxy now (so that I can boot discord). But I do not know how to force a self-update or modules update, so rest of the update functionalities are untested, for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #68.
I am in a network environment where access to discord servers is blocked. I find that the app can't go past the "Starting" screen even with
--proxy-server=<my proxy server>command line argument provided, and error messages about connection timeout are emitted.I suspect the problem is at
src/updater/moduleUpdater.js:6, where thegetfromhttpsnode module instead ofnetfrom electron is used, so proxy settings provided to electron are not respected.According to the source, I set both
SKIP_HOST_UPDATEandSKIP_MODULE_UPDATEtotrue, and the app booted and everything else is fine (I can confirm that the rest of the app is using proxy by proxy server logs and the fact that I can actually connect to discord).This is a usability problem for me, and potentially a privacy problem for some.
I suggest you do a
ctrl-Fonrequire('https')and change accordingly. I am no electron/nodejs expert and dunno if usingelectron/netis the best approach. Just do whatever you see fit to make the updater respect the proxy settings.Overall this is a great based project solving dependency hell problems. Love to all of you.
The text was updated successfully, but these errors were encountered: