Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching krisp module #121

Open
surfaceflinger opened this issue Dec 13, 2022 · 3 comments
Open

Patching krisp module #121

surfaceflinger opened this issue Dec 13, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@surfaceflinger
Copy link

discord_krisp.node has a signature check that verifies if the Discord executable has been modified. This prevents Krisp from being loaded if Discord executable has been for example stripped in repackaging process.

Workaround for that is here NixOS/nixpkgs#195512 (comment)
Perhaps OpenAsar could somehow try to patch krisp after every update? I feel like this might be out of scope though.

@he3als
Copy link

he3als commented Jan 8, 2023

Would be useful for the AUR packages for Discord using the system electron as well.

@CanadaHonk
Copy link
Contributor

I have made this for Mu already (automated) fwiw. Might ship as separate patch/project?

@CanadaHonk CanadaHonk added the enhancement New feature or request label Mar 23, 2023
@surfaceflinger
Copy link
Author

Do whatever you think is better :)

My friend came up with this solution but I guess this will break on updates

xxd -p -c 0 discord_krisp.node | sed -E 's/(4889dfe8........85c0)745c/\19090/' | xxd -p -r -c 0 >discord_krisp_patched.node

@nickname76 nickname76 mentioned this issue Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants