code cleanup around get_source_ibis_table
and get_target_ibis_table
in config_manager.py
#1294
Labels
priority: p2
Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup)
type: cleanup
An internal cleanup or hygiene concern.
Hi,
There is some confusing logic and pre-conditions around these functions. It would be good to have a thorough review and cleanup this code. Specifically this line says:
When you have a custom query - you don't have a target schema and a target table. So this code will most likely fail. It appears that this code is never executed. To make things more interesting
_target_ibis_table
does not appear to be set anywhere or in other places - so not sure how this would work. Same or similar comments on_source_ibis_table
.Things may have evolved since this code was written and this code is no longer needed and could use cleanup. Needs someone with a fresh perspective to review this and cleanup.
Sundar Mudupalli
The text was updated successfully, but these errors were encountered: