Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Cloud Bigtable client version from 0.9.5.1 to 1.5.0 or later #2

Open
mbrukman opened this issue Aug 7, 2018 · 2 comments
Open

Comments

@mbrukman
Copy link

mbrukman commented Aug 7, 2018

The current version of the Dockerfile says:

RUN apt-get update && apt-get install -y autoconf make unzip gnuplot curl git && \
    curl -f http://storage.googleapis.com/cloud-bigtable/hbase-dist/hbase-1.2.1/hbase-1.2.1-bin.tar.gz | tar zxf -  && \
    mkdir -p hbase-1.2.1/lib/bigtable && \
    curl http://repo1.maven.org/maven2/com/google/cloud/bigtable/bigtable-hbase-1.2/0.9.5.1/bigtable-hbase-1.2-0.9.5.1.jar \
      -f -o hbase-1.2.1/lib/bigtable/bigtable-hbase-1.2-0.9.5.1.jar && \
    curl http://repo1.maven.org/maven2/io/netty/netty-tcnative-boringssl-static/1.1.33.Fork19/netty-tcnative-boringssl-static-1.1.33.Fork19.jar \
      -f -o hbase-1.2.1/lib/netty-tcnative-boringssl-static-1.1.33.Fork19.jar && \
    echo 'export HBASE_CLASSPATH="$HBASE_HOME/lib/bigtable/bigtable-hbase-1.2-0.9.5.1.jar:$HBASE_HOME/lib/netty-tcnative-boringssl-static-1.1.33.Fork19.jar"' >> /hbase-1.2.1/conf/hbase-env.sh && \
    echo 'export HBASE_OPTS="${HBASE_OPTS} -Xms1024m -Xmx2048m"' >> /hbase-1.2.1/conf/hbase-env.sh

This is installing Cloud Bigtable client 0.9.5.1, which is quite old: the latest release of Cloud Bigtable client, as of this writing, is 1.5.0.

Also, installing tcnative, netty, etc. is probably no longer necessary with later versions.

As a simpler short-term fix, please consider upgrading the client version and removing extra dependencies.

As a longer-term (or alternative) fix, please consider using released binaries (as per issue #1), which avoids the entire expensive build process altogether.

/cc: @sduskis, @igorbernstein2, @ghaisa (FYI)

@igorbernstein2
Copy link

I'm a bit confused here. Why is the hbase distribution necessary for running opentsdb on top of bigtable? Also, why does the bigtable hbase connector need to be built separately from opentsdb? doesn't opentsdb already build asyncbigtable-0.3.0-jar-with-dependencies.jar?

I'm wondering if the instructions can just be simplified to simply download a binary distribution of opentsdb and fetch asyncbigtable-0.3.0-jar-with-dependencies.jar from mvn central?

For the short term, please:

  • replace bigtable-hbase-1.2-0.9.5.1.jar with bigtable-hbase-1.x-hadoop-1.5.0
  • remove netty-tcnative-boringssl-static-1.1.33.Fork19.jar
  • add io.dropwizard.metrics:metrics-core:3.1.2

@mbrukman
Copy link
Author

mbrukman commented Aug 7, 2018

@igorbernstein2 wrote:

I'm a bit confused here. Why is the hbase distribution necessary for running opentsdb on top of bigtable? Also, why does the bigtable hbase connector need to be built separately from opentsdb? doesn't opentsdb already build asyncbigtable-0.3.0-jar-with-dependencies.jar?

I'm wondering if the instructions can just be simplified to simply download a binary distribution of opentsdb and fetch asyncbigtable-0.3.0-jar-with-dependencies.jar from mvn central?

Yes, that's what I am proposing separately in issue #1. This is suggesting a possibly easier, shorter-term fix to use a newer version of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants