Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instruction to install tox-factor #267

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

DouglasHeriot
Copy link
Contributor

This is no longer necessary with tox version 4, and creates a confusing error message.

rpkilby/tox-factor#18

This is no longer necessary with tox version 4

rpkilby/tox-factor#18
@DouglasHeriot DouglasHeriot marked this pull request as ready for review August 3, 2023 10:39
@DouglasHeriot DouglasHeriot requested a review from a team as a code owner August 3, 2023 10:39
Copy link
Collaborator

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing tox-factor from CI as well?

# Pin tox 3 because of https://github.com/rpkilby/tox-factor/issues/18
run: pip install -U tox==3.27.1 tox-factor

Copy link
Collaborator

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm just saw #268

@aabmass
Copy link
Collaborator

aabmass commented Aug 3, 2023

/gcbrun

@aabmass aabmass enabled auto-merge (squash) August 3, 2023 22:02
@aabmass
Copy link
Collaborator

aabmass commented Aug 3, 2023

/gcbrun

@aabmass aabmass merged commit 5d1e729 into GoogleCloudPlatform:main Aug 3, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants