Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate e2e tests Container Registry usage to Artifact Registry #360

Merged
merged 1 commit into from
Aug 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cloudbuild-e2e-cloud-functions-gen2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,5 @@ steps:

logsBucket: gs://opentelemetry-ops-e2e-cloud-build-logs
substitutions:
_TEST_RUNNER_IMAGE: gcr.io/${PROJECT_ID}/opentelemetry-operations-e2e-testing:0.17.0
_TEST_SERVER_IMAGE: gcr.io/${PROJECT_ID}/opentelemetry-operations-java-e2e-test-server:${SHORT_SHA}
_TEST_RUNNER_IMAGE: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-e2e-testing:0.20.1
_TEST_SERVER_IMAGE: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-java-e2e-test-server:${SHORT_SHA}
4 changes: 2 additions & 2 deletions cloudbuild-e2e-cloud-run.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ steps:

logsBucket: gs://opentelemetry-ops-e2e-cloud-build-logs
substitutions:
_TEST_RUNNER_IMAGE: gcr.io/${PROJECT_ID}/opentelemetry-operations-e2e-testing:0.17.0
_TEST_SERVER_IMAGE: gcr.io/${PROJECT_ID}/opentelemetry-operations-java-e2e-test-server:${SHORT_SHA}
_TEST_RUNNER_IMAGE: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-e2e-testing:0.20.1
_TEST_SERVER_IMAGE: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-java-e2e-test-server:${SHORT_SHA}
4 changes: 2 additions & 2 deletions cloudbuild-e2e-gae.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ steps:

logsBucket: gs://opentelemetry-ops-e2e-cloud-build-logs
substitutions:
_TEST_RUNNER_IMAGE: gcr.io/${PROJECT_ID}/opentelemetry-operations-e2e-testing:0.17.0
_TEST_SERVER_IMAGE: gcr.io/${PROJECT_ID}/opentelemetry-operations-java-e2e-test-server:${SHORT_SHA}
_TEST_RUNNER_IMAGE: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-e2e-testing:0.20.1
_TEST_SERVER_IMAGE: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-java-e2e-test-server:${SHORT_SHA}
4 changes: 2 additions & 2 deletions cloudbuild-e2e-gce.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ steps:

logsBucket: gs://opentelemetry-ops-e2e-cloud-build-logs
substitutions:
_TEST_RUNNER_IMAGE: gcr.io/${PROJECT_ID}/opentelemetry-operations-e2e-testing:0.17.0
_TEST_SERVER_IMAGE: gcr.io/${PROJECT_ID}/opentelemetry-operations-java-e2e-test-server:${SHORT_SHA}
_TEST_RUNNER_IMAGE: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-e2e-testing:0.20.1
_TEST_SERVER_IMAGE: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-java-e2e-test-server:${SHORT_SHA}
4 changes: 2 additions & 2 deletions cloudbuild-e2e-gke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ steps:

logsBucket: gs://opentelemetry-ops-e2e-cloud-build-logs
substitutions:
_TEST_RUNNER_IMAGE: gcr.io/${PROJECT_ID}/opentelemetry-operations-e2e-testing:0.17.0
_TEST_SERVER_IMAGE: gcr.io/${PROJECT_ID}/opentelemetry-operations-java-e2e-test-server:${SHORT_SHA}
_TEST_RUNNER_IMAGE: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-e2e-testing:0.20.1
_TEST_SERVER_IMAGE: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-java-e2e-test-server:${SHORT_SHA}
33 changes: 6 additions & 27 deletions cloudbuild-e2e-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,40 +12,19 @@
# See the License for the specific language governing permissions and
# limitations under the License.
steps:
# If the image doesn't exist, create a skip file for the next step to know
- name: "gcr.io/cloud-builders/gcloud"
entrypoint: "bash"
args:
- -c
- |
existing_tags=$(
gcloud container images list-tags \
--filter="tags:${SHORT_SHA}" --format=json \
${_TEST_SERVER_IMAGE_NAME}
)

if [ "$existing_tags" == "[]" ]; then
echo "Image doesn't exist, will build it"
else
echo "Image already exists, will skip building"
touch skip
fi

# If skip doesn't exist, build and push
- name: docker
id: build-test-server
entrypoint: "sh"
args:
- -c
- |
if [ -e "skip" ]; then
return
else
docker build --tag=${_TEST_SERVER_IMAGE} --file=e2e.Dockerfile .
docker push ${_TEST_SERVER_IMAGE}
if docker manifest inspect ${_TEST_SERVER_IMAGE} > /dev/null; then
echo "Image already exists, will skip building"
exit
fi
docker build --tag=${_TEST_SERVER_IMAGE} --file=e2e.Dockerfile .
docker push ${_TEST_SERVER_IMAGE}

logsBucket: gs://opentelemetry-ops-e2e-cloud-build-logs
substitutions:
_TEST_SERVER_IMAGE: ${_TEST_SERVER_IMAGE_NAME}:${SHORT_SHA}
_TEST_SERVER_IMAGE_NAME: gcr.io/${PROJECT_ID}/opentelemetry-operations-java-e2e-test-server
_TEST_SERVER_IMAGE_NAME: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-java-e2e-test-server
10 changes: 8 additions & 2 deletions cloudbuild-e2e-local.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ steps:
args:
- e2e-test-server/wait-for-image.sh

- name: "docker"
id: pull-image
args:
- pull
- $_TEST_SERVER_IMAGE

# Run the test
- name: $_TEST_RUNNER_IMAGE
id: run-tests-local
Expand All @@ -33,5 +39,5 @@ steps:

logsBucket: gs://opentelemetry-ops-e2e-cloud-build-logs
substitutions:
_TEST_RUNNER_IMAGE: gcr.io/${PROJECT_ID}/opentelemetry-operations-e2e-testing:0.17.0
_TEST_SERVER_IMAGE: gcr.io/${PROJECT_ID}/opentelemetry-operations-java-e2e-test-server:${SHORT_SHA}
_TEST_RUNNER_IMAGE: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-e2e-testing:0.20.1
_TEST_SERVER_IMAGE: us-central1-docker.pkg.dev/${PROJECT_ID}/e2e-testing/opentelemetry-operations-java-e2e-test-server:${SHORT_SHA}
11 changes: 4 additions & 7 deletions e2e-test-server/wait-for-image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,11 @@
# limitations under the License.
#
while true; do
docker pull $_TEST_SERVER_IMAGE
pull_success=$?

if [ $pull_success -ne 0 ]; then
echo "Image couldn't be pulled yet, will continue to retry"
else
echo "Image pulled successfully, continuing onto test"
if docker manifest inspect ${_TEST_SERVER_IMAGE} > /dev/null; then
echo "Image is available, continuing onto test"
break
else
echo "Image not available yet, will continue to retry"
fi
sleep 5
done
Loading