Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CS auto-upgrade support in gkehubfeaturemembership #2654

Open
3 tasks done
ziyue-101 opened this issue Sep 9, 2024 · 1 comment
Open
3 tasks done

Add CS auto-upgrade support in gkehubfeaturemembership #2654

ziyue-101 opened this issue Sep 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ziyue-101
Copy link
Collaborator

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

Add the new field management in the resource backed by the direct controller.

Additional information

No response

Importance

No response

@ziyue-101 ziyue-101 added the enhancement New feature or request label Sep 9, 2024
@ziyue-101
Copy link
Collaborator Author

Can't use the tool to generate the field from the grpc proto.

$ go run . update-types     --parent-message-full-name "google.cloud.gkehub.configmanagement.v1beta.MembershipSpec"     --new-field "cluster"     --api-dir ../../../apis/gkehub/v1beta1
Error: field not found in message
Usage:
   update-types [flags]

Flags:
      --api-dir string                    Base directory for APIs (default "/usr/local/google/home/ziyue/go/src/k8s-config-connector/apis/")
      --api-go-package-path string        Package path (default "github.com/GoogleCloudPlatform/k8s-config-connector/apis/")
  -h, --help                              help for update-types
      --ignored-fields string             Comma-separated list of fields to ignore
      --new-field string                  Name of the new field
      --parent-message-full-name string   Fully qualified name of the proto message holding the new field

Global Flags:
  -v, --api-version string         the KRM API version. used to import the KRM API
      --proto-source-path string   path to (compiled) proto for APIs
  -s, --service string             the GCP service name

field not found in message
exit status 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant