Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(lantern): remove Speedline from Lantern unit test for now #16060

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

connorjclark
Copy link
Collaborator

ref #15841

Lantern expects to be given the result of running Speedline to determine SpeedIndex w/ optimistic mode. Ideally Lantern calls that library itself, but currently left to callers. Since there is no plan I'm aware of to include SpeedIndex in RPP, for now we can defer moving/using Speedline inside Lantern since only Lighthouse needs it. saves some work.

@connorjclark connorjclark requested a review from a team as a code owner June 10, 2024 23:01
@connorjclark connorjclark requested review from adamraine and removed request for a team June 10, 2024 23:01
const data = await getComputationDataFromFixture({trace});
// TODO: observedSpeedIndex is from the Speedline library, and is used for optimistic
// mode. At the moment callers must pass the result into Lantern.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: what is the TODO here? Eventually move speedline inside the lantern library if we need it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@connorjclark connorjclark merged commit d41c7c0 into main Jun 11, 2024
27 checks passed
@connorjclark connorjclark deleted the lantern-speed-index-input branch June 11, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants