Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use page other than chrome://terms for bf-cache gatherer #14665

Open
connorjclark opened this issue Jan 11, 2023 · 7 comments
Open

Use page other than chrome://terms for bf-cache gatherer #14665

connorjclark opened this issue Jan 11, 2023 · 7 comments
Assignees
Labels

Comments

@connorjclark
Copy link
Collaborator

connorjclark commented Jan 11, 2023

// In theory, we should be able to use about:blank here
// but that sometimes produces BrowsingInstanceNotSwapped failures.
// DevTools uses chrome://terms as it's temporary page so we should stick with that.

Marking for 11.0 not because it is a breaking change, but to keep on our radar to check on "sometime in the future".

@adamraine
Copy link
Member

Using about:blank as the temp page still adds an extra "Internal error" when testing bfcache. I'll ping bfcache folks about this again.

@tunetheweb chrome://blank isn't a valid page unfortunately. Do you know any other chrome://xyz pages that might be less confusing to users but still avoid the bugs we see with about:blank.

@tunetheweb
Copy link
Member

Yeah I was suggesting getting the Chrome team to add that page. Not sure of any that would be less confusing to be honest.

@tunetheweb
Copy link
Member

chrome://print/ maybe?

@paulirish paulirish changed the title Use about:blank instead of chrome://terms for bf-cache gatherer Use page other than chrome://terms for bf-cache gatherer Mar 19, 2024
@ghnp5
Copy link

ghnp5 commented Apr 27, 2024

Coming from #15223,
I was now trying to search about why do I see that page on every test! Now I understand :)
It's indeed confusing to us.

@pladaria
Copy link

Is this affecting the LCP metric? My page loads in ~1s but the LCP reports ~10s

@tunetheweb
Copy link
Member

No, LCP is measured as a separate audit before this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants