From d7f76b3db158327a507177fb0517b7037da4ab54 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Mon, 10 Jul 2023 16:24:55 -0700 Subject: [PATCH] fix types --- build/esbuild-plugins.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/build/esbuild-plugins.js b/build/esbuild-plugins.js index 055853e35b9b..c477a597b3c4 100644 --- a/build/esbuild-plugins.js +++ b/build/esbuild-plugins.js @@ -177,7 +177,9 @@ function replaceModules(replaceMap, opts = {disableUnusedError: false}) { */ function ignoreBuiltins(opts = {}) { let builtinList = [...builtin]; - if (opts.exclude) builtinList = builtinList.filter(b => !opts.exclude.includes(b)); + if (opts.exclude) { + builtinList = builtinList.filter(b => !opts?.exclude?.includes(b)); + } const builtinRegexp = new RegExp(`^(${builtinList.join('|')})\\/?(.+)?`); return { name: 'ignore-builtins', @@ -215,7 +217,7 @@ function generateUMD(iifeCode, moduleName) { `root.${moduleComponents[0]}.${moduleComponents[1]} = factory();` : `root.${moduleName} = factory();`; // TODO: we need to change `Lighthouse.ReportGenerator.ReportGenerator` to `Lighthouse.ReportGenerator` in CDT. - const devtoolsHack = moduleName === 'Lighthouse.ReportGenerator' ? + const devtoolsHack = moduleName === 'Lighthouse.ReportGenerator' ? 'root.Lighthouse.ReportGenerator.ReportGenerator = root.Lighthouse.ReportGenerator;' : '';