From 2bd5e7e70d77f0245d766f287d171f4d99d0e088 Mon Sep 17 00:00:00 2001 From: Adam Raine <6752989+adamraine@users.noreply.github.com> Date: Tue, 11 Jul 2023 14:34:58 -0700 Subject: [PATCH] tests(devtools): sync e2e (#15250) --- third-party/devtools-tests/e2e/lighthouse/navigation_test.ts | 5 +---- third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts | 5 ----- third-party/devtools-tests/e2e/lighthouse/timespan_test.ts | 5 ----- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/third-party/devtools-tests/e2e/lighthouse/navigation_test.ts b/third-party/devtools-tests/e2e/lighthouse/navigation_test.ts index 999cf4869c8c..bfdfd44b0be5 100644 --- a/third-party/devtools-tests/e2e/lighthouse/navigation_test.ts +++ b/third-party/devtools-tests/e2e/lighthouse/navigation_test.ts @@ -27,7 +27,6 @@ import { setLegacyNavigation, setThrottlingMethod, setToolbarCheckboxWithText, - unregisterAllServiceWorkers, waitForResult, } from '../helpers/lighthouse-helpers.js'; @@ -62,9 +61,7 @@ describe('Navigation', async function() { }); afterEach(async function() { - await unregisterAllServiceWorkers(); - - const {frontend} = await getBrowserAndPages(); + const {frontend} = getBrowserAndPages(); frontend.off('console', consoleListener); if (this.currentTest?.isFailed()) { diff --git a/third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts b/third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts index 680e9307894a..793783f433a3 100644 --- a/third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts +++ b/third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts @@ -14,7 +14,6 @@ import { navigateToLighthouseTab, registerServiceWorker, selectMode, - unregisterAllServiceWorkers, waitForResult, } from '../helpers/lighthouse-helpers.js'; @@ -39,10 +38,6 @@ describe('Snapshot', async function() { expectError(/Protocol Error: the message with wrong session id/); }); - afterEach(async () => { - await unregisterAllServiceWorkers(); - }); - it('successfully returns a Lighthouse report for the page state', async () => { await navigateToLighthouseTab('lighthouse/hello.html'); await registerServiceWorker(); diff --git a/third-party/devtools-tests/e2e/lighthouse/timespan_test.ts b/third-party/devtools-tests/e2e/lighthouse/timespan_test.ts index feee46cb4086..7a0753f39e09 100644 --- a/third-party/devtools-tests/e2e/lighthouse/timespan_test.ts +++ b/third-party/devtools-tests/e2e/lighthouse/timespan_test.ts @@ -17,7 +17,6 @@ import { selectDevice, selectMode, setThrottlingMethod, - unregisterAllServiceWorkers, waitForResult, waitForTimespanStarted, } from '../helpers/lighthouse-helpers.js'; @@ -43,10 +42,6 @@ describe('Timespan', async function() { expectError(/Protocol Error: the message with wrong session id/); }); - afterEach(async () => { - await unregisterAllServiceWorkers(); - }); - it('successfully returns a Lighthouse report for user interactions', async () => { await navigateToLighthouseTab('lighthouse/hello.html'); await registerServiceWorker();