Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in theta calculation #16

Open
mustaphamodaffar opened this issue Nov 27, 2023 · 0 comments
Open

Typo in theta calculation #16

mustaphamodaffar opened this issue Nov 27, 2023 · 0 comments

Comments

@mustaphamodaffar
Copy link

mustaphamodaffar commented Nov 27, 2023 •
edited
Loading

covariate-adjustment-blogpost/src/adjustment_methods.py

Line 12 in 37ee676

theta = df.cov().loc[prediction_column, "Y"] / df.cov().loc[prediction_column, "Y"]

Currently theta evaluates to 1 since the numerator is identical to the denominator. The denominator should be the variance of the covariate:
df[prediction_column].var()
mustaphamodaffar added a commit to mustaphamodaffar/covariate-adjustment-blogpost that referenced this issue Nov 27, 2023
@mustaphamodaffar
Resolves Glovo#16
e4c1745
@mustaphamodaffar mustaphamodaffar mentioned this issue Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mustaphamodaffar