Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancelling a root vault causes owner == 0 [?] #40

Open
adria0 opened this issue Apr 28, 2017 · 1 comment
Open

cancelling a root vault causes owner == 0 [?] #40

adria0 opened this issue Apr 28, 2017 · 1 comment

Comments

@adria0
Copy link

adria0 commented Apr 28, 2017

Since parentVaultController is 0 in root vault, he ower is changed to 0.
( btw, maybe we need to use Owned.changeOwner ?? )

    function cancelVault() onlyOwnerOrParent returns (bool _finished) {
      ...
    owner = parentVaultController;

Is setting owner == 0 an usual behavior?

@GriffGreen
Copy link
Member

wow! Nice catch, it is usual behavior if you want to decentralize your vault... the owner can be set to 0.... but for cancelling the vault, that may not be what we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants