Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in switch network modal on staging #4801

Open
maryjaf opened this issue Oct 1, 2024 · 11 comments
Open

Problem in switch network modal on staging #4801

maryjaf opened this issue Oct 1, 2024 · 11 comments
Assignees

Comments

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 1, 2024

Describe the bug

when the switch network modal is shown in donation page, by tapping on supported network , the switch nework is done but the modal won't be closed and it is shown constantly .

Screen.Recording.2024-10-01.at.11.00.18.PM.mov

cc: @divine-comedian

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Oct 1, 2024
@maryjaf maryjaf changed the title Problem in switch network flow on staging Problem in switch network modal on staging Oct 1, 2024
@maryjaf
Copy link
Collaborator Author

maryjaf commented Oct 2, 2024

It seems this problem is related to this change #4612 (comment)
@MohammadPCh

@maryjaf
Copy link
Collaborator Author

maryjaf commented Oct 2, 2024

It seems last changes made some problem in previous passed scenario, by changing the user the project owner modal is still shown @HrithikSampson

Screen.Recording.2024-10-02.at.2.11.28.PM.mov

@maryjaf
Copy link
Collaborator Author

maryjaf commented Oct 2, 2024

Describe the bug

when the switch network modal is shown in donation page, by tapping on supported network , the switch nework is done but the modal won't be closed and it is shown constantly .

Screen.Recording.2024-10-01.at.11.00.18.PM.mov
cc: @divine-comedian

This problem has been fixed, but is the below screen record is ok? by tapping on op sepolia , switch network is disappeared for a sec and it is shown again
but after switching network it isn't shown again

Screen.Recording.2024-10-02.at.2.13.37.PM.mov

@HrithikSampson @MohammadPCh

@MohammadPCh
Copy link
Collaborator

MohammadPCh commented Oct 2, 2024

@maryjaf Thanks for testing :)
We need to refactor this part, but it's not a blocker for release. So let's release it and then fix this UI problem.
@HrithikSampson can you take this?

@HrithikSampson
Copy link
Collaborator

Sure @MohammadPCh

@maryjaf
Copy link
Collaborator Author

maryjaf commented Oct 2, 2024

It seems last changes made some problem in previous passed scenario, by changing the user the project owner modal is still shown @HrithikSampson

Screen.Recording.2024-10-02.at.2.11.28.PM.mov

can you fix it before release? @HrithikSampson

@HrithikSampson
Copy link
Collaborator

Not Sure

It seems last changes made some problem in previous passed scenario, by changing the user the project owner modal is still shown @HrithikSampson
Screen.Recording.2024-10-02.at.2.11.28.PM.mov

can you fix it before release? @HrithikSampson

@maryjaf
Copy link
Collaborator Author

maryjaf commented Oct 2, 2024

So should we deploy this change with these 2 problems in this release or revert it ? @divine-comedian
cc: @HrithikSampson @MohammadPCh

@maryjaf maryjaf moved this from New Issues to In Progress in All-Devs Oct 3, 2024
@kkatusic kkatusic self-assigned this Oct 9, 2024
@kkatusic kkatusic moved this from In Progress to Code Review/PR in All-Devs Oct 9, 2024
@kkatusic kkatusic moved this from Code Review/PR to QA in All-Devs Oct 10, 2024
@divine-comedian
Copy link
Contributor

@maryjaf it looks like this is ready to be tested again

@maryjaf
Copy link
Collaborator Author

maryjaf commented Oct 10, 2024

It seems last changes made some problem in previous passed scenario, by changing the user the project owner modal is still shown @HrithikSampson

Screen.Recording.2024-10-02.at.2.11.28.PM.mov

this problem hasn't been fixed and after changing account the page should be refreshed @divine-comedian

@maryjaf
Copy link
Collaborator Author

maryjaf commented Oct 10, 2024

Describe the bug
when the switch network modal is shown in donation page, by tapping on supported network , the switch nework is done but the modal won't be closed and it is shown constantly .
Screen.Recording.2024-10-01.at.11.00.18.PM.mov
cc: @divine-comedian

This problem has been fixed, but is the below screen record is ok? by tapping on op sepolia , switch network is disappeared for a sec and it is shown again but after switching network it isn't shown again

Screen.Recording.2024-10-02.at.2.13.37.PM.mov
@HrithikSampson @MohammadPCh

this problem has been fixed @kkatusic @divine-comedian

@divine-comedian divine-comedian moved this from QA to Done in All-Devs Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants