From cd9cf571b0c03332ae732d0bb8b6b31874b662f6 Mon Sep 17 00:00:00 2001 From: Yarden Shoham Date: Fri, 1 Sep 2023 04:26:32 +0300 Subject: [PATCH] Don't ignore change requests when the blocking user is requested to review (#105) It's fine to remove approvals by requesting reviews but we shouldn't remove change requests by requesting reviews Signed-off-by: Yarden Shoham --- src/github.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/github.ts b/src/github.ts index a825550..3fe1da6 100644 --- a/src/github.ts +++ b/src/github.ts @@ -307,10 +307,9 @@ export const getPrReviewers = async ( } } - // any requested reviewers are not approvers nor blockers + // any requested reviewers are not approvers for (const requestedReviewer of pr.requested_reviewers) { approvers.delete(requestedReviewer.login); - blockers.delete(requestedReviewer.login); } return { approvers, blockers };