Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] removing qglviewer::Vec in favour of QVector3D #6

Open
taiya opened this issue Jun 25, 2014 · 4 comments
Open

[enhancement] removing qglviewer::Vec in favour of QVector3D #6

taiya opened this issue Jun 25, 2014 · 4 comments

Comments

@taiya
Copy link

taiya commented Jun 25, 2014

QGLViewer defines yet-another-vector-type. Couldn't you just use the QVector3D that now ships with Qt5? Especially the OpenGL4 API for Qt accepts natively QVector3D, etc...
Because of this incongruence my code is scattered with usages of this function:

#include <QVector3D>
namespace qt{
    inline QVector3D tr(const qglviewer::Vec& v){ 
        return QVector3D(v.x, v.y, v.z); 
    }
}
@GillesDebunne
Copy link
Owner

Yes, that's scheduled. QQuaternion and QMatrix4x4 could also be used, simplifying the code.

However,

  • Qt5 is not so widely adopted, and I don't want to maintain an other version for Qt4
  • This kind of refactoring, including all the examples, requires some time, and it's hard to find.

Also on the list is a switch to a more recent OpenGL rendering. That's the roadmap for libQGL version 3.

@taiya
Copy link
Author

taiya commented Jun 25, 2014

Hi Gilles, great, so perhaps label these kind of stuff as "enhancements" in github, so I avoid creating duplicates :) Unfortunately OpenGL4 in Qt4 was a pain, and that's why I am using Qt5.

@taiya
Copy link
Author

taiya commented Sep 2, 2014

Do you have any expected release date for version 3?
Perhaps it's just simpler to just do OpenGL4/Qt5 and drop back-compatibility.
It's a bold move, but often appreciated.

@GillesDebunne
Copy link
Owner

No time frame. These are just ideas at the moment.

Version 3 would also target a more recent openGL and would be using shaders. Any other ideas (mostly of things to remove) is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants