Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resourcepack hotloading #3143

Closed
TypicalShavonne opened this issue Jul 15, 2022 · 4 comments
Closed

Resourcepack hotloading #3143

TypicalShavonne opened this issue Jul 15, 2022 · 4 comments
Labels
Feature Request A feature request.

Comments

@TypicalShavonne
Copy link
Contributor

TypicalShavonne commented Jul 15, 2022

Describe the bug

Putting a new resourcepack into packs folder while geyser is running and there is another pack already in there would cause none player able to join the server

To Reproduce

  1. Put this pack into packs folder
  2. Start geyser
  3. Overdrive the geysertestpack1.zip with this pack
  4. Join the server

Expected behaviour

Player join the server and download pack2 normally

Screenshots / Videos

image

Server Version and Plugins

[20:06:17 INFO]: Velocity 3.1.2-SNAPSHOT (git-74edac96-b153)
[20:06:17 INFO]: Copyright 2018-2021 Velocity Contributors. Velocity is licensed under the terms of the GNU General Public License v3.
[20:06:17 INFO]: velocitypowered.com - GitHub

Geyser Dump

No response

Geyser Version

[20:06:35 INFO]: This server is running Geyser version 2.1.0-SNAPSHOT (git-local/dev-240af3c) (Java: 1.19, Bedrock: 1.19.0/1.19.2 - 1.19.10)

Minecraft: Bedrock Edition Device/Version

1.19.10

Additional Context

I downloaded this version from jenkins branch feature/extensions latest

@Kas-tle
Copy link
Member

Kas-tle commented Jul 15, 2022

Hot loading has (I believe) never been supported so this is more a feature request. Also I assume you meant 1.19.10 for the version?

@TypicalShavonne
Copy link
Contributor Author

yea, sorry, i fixed it

@Konicai Konicai added the Feature Request A feature request. label Jul 16, 2022
@Konicai
Copy link
Member

Konicai commented Jun 30, 2023

I cannot say whether or not this will be added to Geyser. However, SessionLoadResourcePacksEvent is available within the geyser api, allowing developers to choose which resource packs a client should be sent on the fly.

@onebeastchris
Copy link
Member

You can use /geyser reload to reload the packs that Geyser reads from the pack folders. Hotloading resource packs from the packs folder can't be implemented, as that could result in a multitude of issues, such as an interruption while a pack is being sent to the Bedrock client.
However, #4205 will implement hot-loading for resource packs specified via url - as Geyser will then be able to provide a cached copy of the pack if the download fails.

@onebeastchris onebeastchris closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request A feature request.
Projects
None yet
Development

No branches or pull requests

4 participants