-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable empty prefix warning #438
Comments
Idk If it's needed, since it's just a warning, it not hurt... |
I don't know why you would want to have an option to disable this, does it bother you seeing it when starting up the server? |
It is true that it doesn't hurt to have a warning. But I still prefer to not have any warnings in my console unless they are actually a valid warning.
It actually does bother me a bit. Everytime I start my server I see this message. While the message is valid, my server does not need a username prefix. Therefore the warning message is invalid for me and shouldn't be there imo. |
What do you mean by a valid warning? |
As I have mentioned before my server does not require a username prefix since only Bedrock players use the server. Therefore the message about a empty username prefix is invalid for me. The warning about not running the Minecraft server as a administrator is more a valid warning to me (just to use as an example). |
The warning is here for a reason (even though it does not apply in your case) - you can see the reasoning in the warning. In case we ever would add an option to turn it off, it might be a system property. Personally, i do not see a reason to add it since it's a mere console warning. If it bothers you, you can use something like https://www.spigotmc.org/resources/console-spam-fix.18410/ or https://modrinth.com/plugin/logfilter to hide the warning yourself. |
If we were to address this on our end, then we could add a system property for it. A config option would imply endorsement of empty prefixes. |
Your usecase does rase an interesting point. We do for example have an option that only allows linked Bedrock players to join. In that case the empty username prefix message should not have to appear (which I believe it does atm.) I think we could probably also add an option that only allows Floodgate (aka Bedrock) players to join a server, in which case this message should also not show up. But a config option to disable the warning message won't be added, as it'd be seen as an endorcement like Camotoy says. |
Not to self-plug, but GeyserBlockJavaPlayers does exist. I think its better suited as something separate in order to avoid Floodgate modifying the server more than it needs to in order to accomplish its main goal |
Personally I don't see why we couldn't just add a system property. This is how we've treated things in Geyser where while we similarly feel that the warning should be there in 99.9% of cases (e.g. secure profiles), if someone really wants to disable it they can take the affirmative action of enabling the system property. |
I'd rather add a config option that has some use than a system property for a message that only shows up once |
I have a proposal for an extra configuration settings that will disable the empty prefix warning.
I have a java server with Geyser and Floodgate. The server is a private one and all the players on their only use Bedrock edition. Everytime when starting my server I get the following message:
While I understand that this warning is good and useful to alert the server administrator that this should have a value. It would be nice in my opinion if a option like
allow-empty-prefix
could be added.When
allow-empty-prefix
has been set totrue
it would stop the warning from being send in the server console.The text was updated successfully, but these errors were encountered: