-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Demo App Refresh Tokens + Connection Banner #3313
Fix Demo App Refresh Tokens + Connection Banner #3313
Conversation
Generated by 🚫 Danger |
I was thinking about bottom placement when I tried this (since now it appears always) but I guess it is fine to see it at the top as well. Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-18.at.09.45.54.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Showing it always for a split second is a bit too much imo. We could add a loading spinner instead of the avatar on the top left while connecting maybe?
In any case, I would park this for now until we have a better way.
@martinmitrevski I've hidden this behind a flag in the demo app |
🔗 Issue Links
Related to https://stream-io.atlassian.net/browse/PBE-4780
🎯 Goal
Fixes the issues found in the Demo App from this PR.
It is important to fix them in a separate PR, so that we can compare the new fixes vs the old implementation. Since showing the connection banner helps us understand the connecting state transitions.
🧪 Manual Testing Notes
N/A
☑️ Contributor Checklist