Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Demo App Refresh Tokens + Connection Banner #3313

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

nuno-vieira
Copy link
Member

🔗 Issue Links

Related to https://stream-io.atlassian.net/browse/PBE-4780

🎯 Goal

Fixes the issues found in the Demo App from this PR.

It is important to fix them in a separate PR, so that we can compare the new fixes vs the old implementation. Since showing the connection banner helps us understand the connecting state transitions.

🧪 Manual Testing Notes

N/A

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added the 🪧 Demo App An Issue or PR related to the Demo App label Jul 17, 2024
@nuno-vieira nuno-vieira requested a review from a team as a code owner July 17, 2024 23:57
Copy link

1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 🚫 Danger

@laevandus
Copy link
Contributor

laevandus commented Jul 18, 2024

I was thinking about bottom placement when I tried this (since now it appears always) but I guess it is fine to see it at the top as well.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-18.at.09.45.54.mp4

Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Showing it always for a split second is a bit too much imo. We could add a loading spinner instead of the avatar on the top left while connecting maybe?
In any case, I would park this for now until we have a better way.

@nuno-vieira
Copy link
Member Author

@martinmitrevski I've hidden this behind a flag in the demo app

@nuno-vieira nuno-vieira enabled auto-merge (squash) July 18, 2024 10:21
@nuno-vieira nuno-vieira merged commit dda5165 into develop Jul 18, 2024
13 checks passed
@nuno-vieira nuno-vieira deleted the demo-app/fix-connection-banner-not-showing branch July 18, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪧 Demo App An Issue or PR related to the Demo App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants