Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with slimefun4 #111

Open
BrLuquinha19 opened this issue Jan 8, 2022 · 6 comments
Open

Compatibility with slimefun4 #111

BrLuquinha19 opened this issue Jan 8, 2022 · 6 comments
Labels
bug:possible It's unclear whether the bug actually is existing or a false report is underlying compatibility:plugins compatibility with other plugins

Comments

@BrLuquinha19
Copy link

Basically, there is a very popular plugin called slimefun4, that adds a lot of cool things, some of them are auto enchanters, disenchanters and book binders, that can extract enchantments from items to books, apply enchantments to items from books, and make overlevel enchantments with 2 books (like unbreaking 3 + unbreaking 3 = unbreaking 4)
I have both enchantments plus and slimefun4 on my server, but slimefun machines cant affect enchantments plus`s enchantments

@BrLuquinha19
Copy link
Author

My suggestion is to add compatibility with it, so we can use slimefun machines to work with enchantments+`s enchantments

@Geolykt
Copy link
Owner

Geolykt commented Jan 8, 2022

Notes upfront

Overlevelled enchantments are not supported unless as it bricks at level 11 and will display level 0 for the PDC while the lore getter will not only display level 0 it will also be level 0.

Regarding the actual issue

Actual Slimefun4 compat would be a fun one to implement as I would be surprised if they had some API in case someone was doing custom enchantments without using unsupported registries (as pretty much all CE plugins use those unsupported registries, but we do not (yet)).

Will this be fixed

Very likely as a side effect of fixing the series of bugs like #97. I've been thinking of doing that for a while now but haven't really since this plugin is kinda on ice for the time being

@Geolykt Geolykt added bug:possible It's unclear whether the bug actually is existing or a false report is underlying compatibility:plugins compatibility with other plugins labels Jan 8, 2022
@GentlemanCheesy
Copy link

Really would love to see this added sometime, if you need help with info on Slimefun's api I am friends with one of the most notable addon creators for the base plugin, and could probably ask him to answer some questions if you have any!

@Geolykt
Copy link
Owner

Geolykt commented Feb 20, 2022

I'll take a poke at it someday, don't worry

@Geolykt
Copy link
Owner

Geolykt commented Apr 9, 2022

Okay, after a quick conversation with slimefun contributors we came to the conclusion that slimefun in the current state does not support such compatibility. I'll do a PR to add the needed API, after it gets accepted there will be the possibility rudimentary support. (I'll try to add Auto(Dis-)Enchanter support at the very minimum)

Geolykt added a commit that referenced this issue Aug 11, 2022
One step closer towards #111. However no man should ever have use ASM, UnsafeValues
AND sun.misc.Unsafe just to provide compatibility with a plugin. Oh whatever,
I like writing transformers either way even if it takes ages to do.
@Geolykt
Copy link
Owner

Geolykt commented Sep 21, 2022

Since Slimefun/Slimefun4#3526 has shown me that it takes an INCREDIBLY long time to get anything into the slimefun core and the Hackloader approach has proved to be stupid (I'm not going to sit and code some incredibly brittle "API" for over 30 hours for something that can be written in 5 hours if done in an orderly fashion). As such I believe that anyone that wants such compatibility needs to prepare for a long wait. Not much I can do about it other than obnoxiously annoying other devs, which I rather despise doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:possible It's unclear whether the bug actually is existing or a false report is underlying compatibility:plugins compatibility with other plugins
Projects
None yet
Development

No branches or pull requests

3 participants