Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 4.4.x] [Fixes #11703] Documents can now be uploaded without specifying title via the REST API. #12612

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport 852ce01 from #11872.

… via the REST API. (#11872)

* Documents can now be uploaded without specifying title via the REST API.

* Added test for document upload without title.

* Fixed the document upload without title test.

* Fixed linting issues.

* Fixed tests for uploading document without a title.

* Fixed Documents serializer.

* Added file name as title when no title is provided.

* Fixed tests for uploading document without a title.

* 1- Using the name of the file as a title for document upload if no title is specified instead of 'None'.
2- Fixed test for uploading document without a title.

* Fixed the test for document upload without a title.

---------

Co-authored-by: Giovanni Allegri <[email protected]>
(cherry picked from commit 852ce01)
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.27%. Comparing base (c5cebd8) to head (d4283fd).
Report is 1 commits behind head on 4.4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            4.4.x   #12612      +/-   ##
==========================================
+ Coverage   64.25%   64.27%   +0.01%     
==========================================
  Files         888      888              
  Lines       53624    53635      +11     
  Branches     6609     6609              
==========================================
+ Hits        34458    34475      +17     
+ Misses      17651    17649       -2     
+ Partials     1515     1511       -4     

@giohappy giohappy merged commit 45eaa02 into 4.4.x Sep 24, 2024
12 checks passed
@giohappy giohappy deleted the backport-11872-to-4.4.x branch September 24, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants