Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor DB username as set in env file #11522

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

etj
Copy link
Contributor

@etj etj commented Sep 22, 2023

Ref #11513
Use the DATABASE_URL if it exists, otherwise create it by also using the username.

Checklist

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj linked an issue Sep 22, 2023 that may be closed by this pull request
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Sep 22, 2023
@etj etj requested a review from giohappy September 22, 2023 13:18
@etj etj added the master label Sep 22, 2023
@etj etj force-pushed the 11513-honor-db-username-as-set-in-env-file branch from f78e1f6 to 1e03cc9 Compare September 22, 2023 13:20
@giohappy
Copy link
Contributor

@etj to be done also for geonode-project

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #11522 (1e03cc9) into master (80e2bbf) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11522      +/-   ##
==========================================
- Coverage   62.05%   62.05%   -0.01%     
==========================================
  Files         867      867              
  Lines       51724    51724              
  Branches     6469     6469              
==========================================
- Hits        32098    32095       -3     
- Misses      18086    18088       +2     
- Partials     1540     1541       +1     

@giohappy giohappy merged commit 530a44e into master Sep 22, 2023
16 of 17 checks passed
@giohappy giohappy deleted the 11513-honor-db-username-as-set-in-env-file branch September 22, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honor DB username as set in env file
2 participants