Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11273] Faceting: /facets loses some filters along the way #11274

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

etj
Copy link
Contributor

@etj etj commented Jul 17, 2023

#11273

Checklist

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj requested a review from mattiagiupponi July 17, 2023 15:35
@etj etj self-assigned this Jul 17, 2023
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #11274 (a772d50) into master (9104553) will increase coverage by 0.01%.
The diff coverage is 94.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11274      +/-   ##
==========================================
+ Coverage   61.59%   61.61%   +0.01%     
==========================================
  Files         845      845              
  Lines       52305    52336      +31     
  Branches     6697     6703       +6     
==========================================
+ Hits        32216    32245      +29     
  Misses      18538    18538              
- Partials     1551     1553       +2     

@etj etj merged commit b3f3764 into master Jul 17, 2023
10 checks passed
@etj etj deleted the 11273-faceting-facets-loses-some-filters-along-the-way branch July 17, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants