Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11101] Faceting: keywords #11231

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[Fixes #11101] Faceting: keywords #11231

merged 1 commit into from
Jul 7, 2023

Conversation

etj
Copy link
Contributor

@etj etj commented Jul 6, 2023

Implements #11101

Creates a new FacetProvider KeywordFacetProvider

Checklist

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj self-assigned this Jul 6, 2023
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #11231 (48959a9) into master (f839d39) will increase coverage by 0.00%.
The diff coverage is 82.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11231   +/-   ##
=======================================
  Coverage   61.29%   61.30%           
=======================================
  Files         840      841    +1     
  Lines       51934    51966   +32     
  Branches     6669     6672    +3     
=======================================
+ Hits        31834    31858   +24     
- Misses      18565    18573    +8     
  Partials     1535     1535           

@etj etj force-pushed the 11101-faceting-keywords branch from 48959a9 to ea8723f Compare July 7, 2023 10:06
@etj etj merged commit 0bb04fe into master Jul 7, 2023
7 checks passed
@etj etj deleted the 11101-faceting-keywords branch July 7, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants