Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11097] Faceting: resource type #11222

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

etj
Copy link
Contributor

@etj etj commented Jul 4, 2023

Implements #11097

Creates 2 new FacetProviders,

  • ResourceTypeFacetProvider: provides faceting for resources types (dataset, maps, ..) and subtypes(raster, vector, ...)
  • FeaturedFacetProvider: provides faceting for featured flag.

Checklist

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 4, 2023
@etj etj added this to the 4.2.0 milestone Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #11222 (70fc7ef) into master (543d751) will increase coverage by 0.03%.
The diff coverage is 91.17%.

❗ Current head 70fc7ef differs from pull request most recent head 69b6af4. Consider uploading reports for the commit 69b6af4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11222      +/-   ##
==========================================
+ Coverage   61.26%   61.29%   +0.03%     
==========================================
  Files         839      840       +1     
  Lines       51877    51934      +57     
  Branches     6658     6669      +11     
==========================================
+ Hits        31783    31834      +51     
- Misses      18563    18565       +2     
- Partials     1531     1535       +4     

@etj etj force-pushed the 11097-faceting-resource-type branch from 70fc7ef to 69b6af4 Compare July 6, 2023 15:28
@etj etj merged commit f839d39 into master Jul 6, 2023
11 checks passed
@etj etj deleted the 11097-faceting-resource-type branch July 6, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API v2 cla-signed CLA Bot: community license agreement signed master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants